Show property name on failing JSON schema assertions#105
Show property name on failing JSON schema assertions#105TavoNiievez merged 2 commits intoCodeception:masterfrom
Conversation
|
@francislavoie I wonder if the tests could be adjusted to verify that the new logic works as expected. This can be achieved by adjusting the expected exception messages in https://github.com/francislavoie/module-rest/blob/abc599a9992db4ed2d6f6165a6b3ad8fe901ae89/tests/unit/Codeception/Module/RestTest.php#L715. WDYT? |
|
Sorry for the wait, added a test @W0rma |
francislavoie
force-pushed
the
patch-1
branch
from
309c466 to
46d25c2
Compare
|
FYI @TavoNiievez just in case this got missed 🙏 |
|
@W0rma @TavoNiievez Could we please merge this? Every time I have schema failures in our tests, we're wasting lots of time to drill down to debug why the schema failed. This would save us so much time if you could merge this 🙏 |
|
@francislavoie It seems that the tests are failing now. Can you verify why? |
|
Tests are failing on |
|
Oh, okay thanks |
|
@TavoNiievez #113 should fix the tests. It would be great if you could also merge #109 and tag a new release as proposed in #112 |
3 participants
Fixes #104